This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(hooks): avoid effect in useStableValue #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There's no tests for this, so make sure that the timings we had are still the same. specifically used in: https://github.com/algolia/react-instantsearch/blob/f436d31184f3f75b33a1fdaa19c665e77948df28/packages/react-instantsearch-hooks/src/hooks/useConnector.ts#L26-L29 https://github.com/algolia/react-instantsearch/blob/aa5f9d84ddb6e97d05e6ad1baf2c6caa23891281/packages/react-instantsearch-hooks/src/lib/useIndex.ts#L22
Haroenv
requested review from
francoischalifour,
a team,
FabienMotte and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9a94428:
|
✅ Deploy Preview for react-instantsearch ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
francoischalifour
approved these changes
Oct 28, 2022
FabienMotte
approved these changes
Oct 28, 2022
sarahdayan
approved these changes
Oct 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no tests for this, so make sure that the timings we had are still the same.
specifically used in:
react-instantsearch/packages/react-instantsearch-hooks/src/hooks/useConnector.ts
Lines 26 to 29 in f436d31
react-instantsearch/packages/react-instantsearch-hooks/src/lib/useIndex.ts
Line 22 in aa5f9d8
same as https://github.com/algolia/predict/pull/45