chore(Dependencies): update major ones #41
Conversation
aaaa prop-types fixes #20
| HotModuleReplacementPlugin, | ||
| NoEmitOnErrorsPlugin, | ||
| } = webpack; | ||
| const { HotModuleReplacementPlugin, NoEmitOnErrorsPlugin } = webpack; |
There was a problem hiding this comment.
destructuring was using same logic as objects before prettier/prettier#981
| }, | ||
| {} | ||
| ); | ||
| const facets = props.attributes.reduce((acc, attributeName) => { |
There was a problem hiding this comment.
| export default function Highlighter( | ||
| { hit, attributeName, highlight, highlightProperty, tagName } | ||
| ) { | ||
| export default function Highlighter({ |
There was a problem hiding this comment.
There was a problem hiding this comment.
Shouldn't we do also createReactClass? see: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.createclass
Also it seems that you missed a PropTypes from react-router-v4. Did you do it by hand?
|
I did it with a codemod everywhere in |
|
There are some Also, one check we could do, is verifying that we don't have any warnings left inside recipes/demos/storybook. |
|
All those issues should now be fixed. |
Haroenv
force-pushed
the
chore/update-deps
branch
3 times, most recently
from
6526e3f
to
b717bb3
Compare
Haroenv
force-pushed
the
chore/update-deps
branch
from
b717bb3
to
3b6769f
Compare
| @@ -3,7 +3,7 @@ This example shows how to perform a geo search using `react-instantsearch`. | |||
| To start the example: | |||
|
|
|||
| ```sh | |||
| yarn install --no-lockfile | |||
| yarn install | |||
There was a problem hiding this comment.
why removing the --no-lockfile?
There was a problem hiding this comment.
I don't see the value of writing --no-lockfile here.
There was a problem hiding this comment.
It's there to not create a lock file when checkouting and running the examples. (and its present in every examples).
No matter what, this is not related to the dependencies upgrade.
| @@ -37,5 +37,5 @@ do | |||
| -o "${dist_file_min}" | |||
|
|
|||
| gzip_size=$(gzip -9 < "$dist_file_min" | wc -c | pretty-bytes) | |||
| echo "=> $dist_file_min gzipped will weight $gzip_size" | |||
| echo "=> $dist_file_min gzipped will weigh $gzip_size" | |||
There was a problem hiding this comment.
It's one that's on lots of places, so I change them one by one 😄
Summary
Result
fixes #20