Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static code error in Searchable\Aggregator.php #330

Open
jnoordsij opened this issue Oct 12, 2023 · 0 comments
Open

Fix static code error in Searchable\Aggregator.php #330

jnoordsij opened this issue Oct 12, 2023 · 0 comments

Comments

@jnoordsij
Copy link

  • Laravel version: latest (CI)
  • Algolia Scout Extended version: latest (CI)
  • Algolia Client Version: n/a
  • Language Version: any

Description

With the latest larastan version installed, the following error appears when running static analysis:

 ------ ------------------------------------------------------------------------------------
  Line   Searchable\Aggregator.php
 ------ ------------------------------------------------------------------------------------
  266    Call to an undefined method Illuminate\Database\Eloquent\Model::searchableUsing().
 ------ ------------------------------------------------------------------------------------

A possible solution would be working with the laravel/scout repository to add a proper contract to allow for better type-hints; see also laravel/scout#771.

Steps To Reproduce

Run composer update followed by composer test.

See any recently created CI test job, e.g. https://app.circleci.com/pipelines/github/algolia/scout-extended/255/workflows/ec6dc973-ce16-4d43-82e8-a61c2b2b4cd4/jobs/2079/parallel-runs/0/steps/0-109.

@jnoordsij jnoordsij changed the title Fix failing CI test job Fix static code error in Searchable\Aggregator.php Oct 12, 2023
jnoordsij added a commit to jnoordsij/scout-extended that referenced this issue Oct 12, 2023
This is a workaround for algolia#330 that allows CI to succeed again
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant