Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: circumvent queue when using aggregators #287

Merged
merged 2 commits into from
Feb 23, 2022
Merged

Conversation

DevinCodes
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related Issue Fix #282

Describe your change

This PR adds a change to circumvent the queue when using aggregators.

What problem is this fixing?

See #282

@DevinCodes
Copy link
Contributor Author

@damcou Could you review this PR when you have some spare time, please? 😄

@JayBizzle
Copy link
Contributor

On Monday we are going to pull this fix into our production environment and run it for a couple of days and see how it copes. Will report back if this hasn't been merged by then 👍

@JayBizzle
Copy link
Contributor

We now have this PR running in our production environment.

Initial tests show that everything is running great, but we are going to leave it a few days and report back 👍🏻

@JayBizzle
Copy link
Contributor

Been running this code now for 5 days with no reported issues. I'd say it is good to go 👍🏻

@DevinCodes
Copy link
Contributor Author

That's awesome, thank you for reporting back @JayBizzle !

I'll reach out to @damcou for PR approval so we can release this this week 🙂

damcou
damcou previously approved these changes Feb 21, 2022
Copy link

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops sorry, I missed the first ping apparently.
Looks good to me 🚀

Copy link

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DevinCodes DevinCodes merged commit b2dc355 into master Feb 23, 2022
@DevinCodes DevinCodes deleted the fix/aggregator-queue branch February 23, 2022 13:49
@DevinCodes
Copy link
Contributor Author

@JayBizzle This is available in v2.0.2 which was just released! I'm releasing a patch for v1 in a bit (see #303)

@JayBizzle
Copy link
Contributor

Brilliant, thank you 👍🏻

@jackdaniel9
Copy link

Error again with 2.0.2 : Model not defined in aggregator.

if ($this->model === null) {
throw new ModelNotDefinedInAggregatorException();
}

Controller:

Product::find($id)->delete();

@bakerkretzmar
Copy link
Contributor

bakerkretzmar commented May 16, 2022

@jackdaniel9 likely related to #305

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregators broken since laravel/scout was updated to v9.1.0 when deleting Models became queueable
5 participants