Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: register macros #310

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: register macros #310

merged 1 commit into from
Jun 20, 2022

Conversation

DevinCodes
Copy link
Contributor

@DevinCodes DevinCodes commented Jun 20, 2022 •
edited

This fixes a bug introduced in the last release where macros for Aggregators were not registered, which causes issues when models in the aggregator don't have the Searchable trait.

@JayBizzle JayBizzle mentioned this pull request Jun 20, 2022
Merged
@DevinCodes DevinCodes marked this pull request as ready for review June 20, 2022 14:17
@DevinCodes DevinCodes requested a review from damcou June 20, 2022 14:19
damcou
damcou approved these changes Jun 20, 2022
View reviewed changes
Copy link

@damcou damcou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@DevinCodes DevinCodes merged commit bb16187 into master Jun 20, 2022
@DevinCodes DevinCodes deleted the DevinCodes-patch-1 branch June 20, 2022 14:22
@DevinCodes
Copy link
Contributor Author

I'm writing a test for this later this week 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damcou damcou damcou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@DevinCodes @damcou