Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(github): ensure release assets are ready before releasing #998

Merged
merged 1 commit into from Apr 5, 2023
Merged

fix(github): ensure release assets are ready before releasing #998

merged 1 commit into from Apr 5, 2023

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Apr 5, 2023 •
edited

This PR enforces the asynchronous nature of the Github Release Asset method.

Within a CI environment

  • We ensure that assets are uploaded one after the other (as part of the release) prior to the next step in the CI (or CI termination)

@writeens writeens changed the title fix: add await keyword for improved asynchronous functionality fix: add await keyword to github asset release for improved asynchronous functionality Apr 5, 2023
@writeens writeens marked this pull request as ready for review April 5, 2023 15:31
@writeens writeens requested a review from Haroenv April 5, 2023 15:31
@writeens writeens changed the title fix: add await keyword to github asset release for improved asynchronous functionality fix(github): ensure assets are ready before releasing Apr 5, 2023
@writeens writeens changed the title fix(github): ensure assets are ready before releasing fix(github): ensure release assets are ready before releasing Apr 5, 2023
@Haroenv Haroenv merged commit 0f92a1b into main Apr 5, 2023
@Haroenv Haroenv deleted the fix/github-release-assets branch April 5, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Haroenv Haroenv Haroenv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@writeens @Haroenv