Added favicon and title #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rayrutjes
requested changes
Oct 6, 2017
static/index.html
Outdated
| @@ -2,6 +2,8 @@ | |||
| <html> | |||
|
|
|||
| <head> | |||
| <title>sup3rS3cretMes5age</title> | |||
| <link rel="icon" tpye="image/png" href="/static/favicon.png"> | |||
|
Thanks for your contribution, we should add a favicon. I don't think that the size is suitable though, favicon usually is 64x64. If we're having a favicon, we should probably have it in a few sizes. I usually like to use realfavicongenerator.net Let's use an original design that works for this size |
|
Thanks a lot for your contribution @Briansbum, thanks again! 👍 |
|
@eranchetz icons have been added from the generator recommended by @Haroenv Sorry for the delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little cosmetic tweak to make the app look better to users.