ci(shipjs): publish packages topographically #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the order of the dependents, and thus if there's some error, we won't have published an impossible state. I didn't search about that yet, but i think lerna can give a list of packages as well, in the right order.
Haroenv
requested review from
sarahdayan,
a team and
FabienMotte
and removed request for
a team
sarahdayan
approved these changes
Oct 17, 2022
Haroenv
added a commit
to algolia/react-instantsearch
that referenced
this pull request
Oct 17, 2022
If we'd use `lerna publish` instead of a publish command per package, this may not be needed, but I couldn't find how to make that work correctly with shipjs just yet. The order is now (note dom-maps is published later): ``` 'packages/react-instantsearch-core', 'packages/react-instantsearch-hooks', 'packages/react-instantsearch-dom', 'packages/react-instantsearch-hooks-server', 'packages/react-instantsearch-hooks-web', 'packages/react-instantsearch-native', 'packages/react-instantsearch-dom-maps', 'packages/react-instantsearch' ``` This is equivalent to algolia/ui-components#23
Haroenv
added a commit
to algolia/react-instantsearch
that referenced
this pull request
Oct 17, 2022
If we'd use `lerna publish` instead of a publish command per package, this may not be needed, but I couldn't find how to make that work correctly with shipjs just yet. The order is now (note dom-maps is published later): ``` 'packages/react-instantsearch-core', 'packages/react-instantsearch-hooks', 'packages/react-instantsearch-dom', 'packages/react-instantsearch-hooks-server', 'packages/react-instantsearch-hooks-web', 'packages/react-instantsearch-native', 'packages/react-instantsearch-dom-maps', 'packages/react-instantsearch' ``` This is equivalent to algolia/ui-components#23
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Jan 4, 2023
…search#3654) If we'd use `lerna publish` instead of a publish command per package, this may not be needed, but I couldn't find how to make that work correctly with shipjs just yet. The order is now (note dom-maps is published later): ``` 'packages/react-instantsearch-core', 'packages/react-instantsearch-hooks', 'packages/react-instantsearch-dom', 'packages/react-instantsearch-hooks-server', 'packages/react-instantsearch-hooks-web', 'packages/react-instantsearch-native', 'packages/react-instantsearch-dom-maps', 'packages/react-instantsearch' ``` This is equivalent to algolia/ui-components#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If anything goes wrong, like npm being down in the middle of publishing, we want to have gotten to a valid state, only having packages that are depended on, not ones that depend on other packages that aren't yet published.
There's two commits here. First a manual reorder, then using lerna and shelljs (dependency of shipjs) to create the list.
After this is done here, we could either build this into shipjs or have this copied into other packages.
What this PR doesn't solve is if there's a failure midway, a rerun will still fail (as the first ones are already published). You'd still do that manually or publish a second patch.