feat: reuse config index name as default sort option #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francoischalifour
approved these changes
Jul 23, 2020
Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're repeating the default index name twice in the config file: under
index.indexNameand undersortsas the first (default) sort-by option. We can remove this and instead reuseindex.indexNamewithin theSearchcomponent.Note that I didn't keep the default label in the configuration to avoid making it more complex than it needs to be. In case users need to change it (which is possible but probably won't happen that much), they can search it through the project and change it without much trouble.
I've also changed the condition for displaying the sorts (more than one vs. more than none) because we don't need to show the widget if we only have the default sorting.