Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Library revamp #33

Merged
merged 14 commits into from Mar 15, 2021
Merged

feat: Library revamp #33

merged 14 commits into from Mar 15, 2021

Conversation

VladislavFitz
Copy link
Contributor

@VladislavFitz VladislavFitz commented Mar 2, 2021 •
edited

  • Transform the library to Swift package
  • Update Cocoapods and Carthage versions and specs
  • Generalize permissions request with PermissionController
  • AVAudioSession: crash fixes (fix AVAudioEngine Exception #29), muting other audio sources while speech recognition
  • Fix issue with unowned view controller capturing causing the crash (fix AVAudioEngine Exception & Crash App #30)

@VladislavFitz VladislavFitz marked this pull request as ready for review March 15, 2021 12:51
@VladislavFitz VladislavFitz merged commit 55a1047 into master Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aallam aallam aallam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AVAudioEngine Exception & Crash App AVAudioEngine Exception
2 participants
@VladislavFitz @aallam