This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ssr): extend component correctly if at root (vue2) #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #1054 Essentially the problem is that $vnode is usually available, but not when the this is a root Vue instance. In that case we are in the "Vue.component" case, which before now always was wrong (it takes two arguments, not one)
Haroenv
requested review from
a team,
dhayab and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b88013d:
|
sarahdayan
reviewed
Jan 31, 2022
sarahdayan
approved these changes
Jan 31, 2022
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Haroenv
added a commit
that referenced
this pull request
Jan 31, 2022
Haroenv
added a commit
that referenced
this pull request
Jan 31, 2022
* fix(server): extend component correctly if at root Essentially the problem is that $vnode is usually available, but not when the this is a root Vue instance. In that case we are in the "Vue.component" case, which before now always was wrong (it takes two arguments, not one) Same as #1104 see also #1054 * Update src/util/createServerRootMixin.js * make the funky new test pass * update test name, as in #1104 * Update src/util/__tests__/createServerRootMixin.test.js Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
This was referenced Jan 31, 2022
Closed
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…nstantsearch#1104) * fix(ssr): extend component correctly if at root (vue2) fixes algolia/vue-instantsearch#1054 Essentially the problem is that $vnode is usually available, but not when the this is a root Vue instance. In that case we are in the "Vue.component" case, which before now always was wrong (it takes two arguments, not one) * not only * Update src/util/__tests__/createServerRootMixin.test.js Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com> Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1054
Essentially the problem is that $vnode is usually available, but not when the this is a root Vue instance. In that case we are in the "Vue.component" case, which before now always was wrong (it takes two arguments, not one)