This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(esm): mark esm exports as type: module #1111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b86eb7d:
|
dhayab
approved these changes
Feb 10, 2022
|
That would be good, but seems like it breaks fsevents on macOS for me, so will do that in a separate PR @dhayab |
Haroenv
added a commit
to algolia/instantsearch
that referenced
this pull request
Dec 28, 2022
…#1111) * chore: import consistently from util * refactor(build): build both vue2 and vue3 with same rollup config * use babel to resolve extension * create package.json and cjs entry * test in ci * split up vue 2 and vue 3 * fix vue3 imports in test * less strict test that doesn't depend on babel version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1098
Notes for review: I refactored the build to not require to separate calls to
rollup, this makes the diff a little harder to follow, as new plugins are also added. You can see the individual commits for each of the steps that happened