This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
fix(ais-hierarchical-menu): show full hierarchical parent values #1126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhayab
requested review from
a team,
FabienMotte and
sarahdayan
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
sarahdayan
reviewed
Jun 17, 2022
Comment on lines
+936
to
+938
| expect(instantsearch.mainIndex.getHelper()).toEqual( | ||
| expect.any(AlgoliaSearchHelper) | ||
| ); |
There was a problem hiding this comment.
Why is this added in this PR?
There was a problem hiding this comment.
As I was going through the tests (I initially had issues due to conflicting versions of algoliasearch-helper), I saw this TODO and I found that it could be solved in a similar manner as in https://github.com/algolia/vue-instantsearch/blob/master/src/util/__tests__/createServerRootMixin.test.js#L970-L975.
There was a problem hiding this comment.
Sure this makes sense, just felt unrelated to the PR, but it's a small change so I guess it's fine :)
Haroenv
approved these changes
Jun 17, 2022
sarahdayan
approved these changes
Jun 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the instantsearch.js dependency to allow the
<ais-hierarchical-menu>widget to retrieve and display the full list of a refined item's parents values.