Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails for en and videoId JueUvj6X3DA #3

Closed
syzer opened this issue May 7, 2018 · 4 comments
Closed

Fails for en and videoId JueUvj6X3DA #3

syzer opened this issue May 7, 2018 · 4 comments

Comments

@syzer
Copy link
Contributor

syzer commented May 7, 2018

Do you accept PR's ?
Because I have a fix and not sure shall I publish fix on npm or PR here..
Ok I did both.
BTW Great work guys.

syzer added a commit to syzer/youtube-captions-scraper that referenced this issue May 7, 2018
@magician11
Copy link

I just tried this..

const { getSubtitles } = require('youtube-captions-scraper');

getSubtitles({
  videoID: 'JueUvj6X3DA',
  lang: 'en'
}).then(captions => {
  console.log(captions);
});

and it works fine. I see there is a PR. Has it not been merged because this works?

@syzer
Copy link
Contributor Author

syzer commented Aug 14, 2018

Maybe now it works... 👍
It wasn't the case earlier.

@rvizcaino80
Copy link

Hi, thanks for the great work. Some videos are still not working for english subtitles!

Try this one Uar2hXRrckY. Thanks.

@syzer
Copy link
Contributor Author

syzer commented Aug 31, 2018

@rvizcaino80
Here's fix for this one :
npm i --save youtube-captions-scraper-fix

drorgl pushed a commit to drorgl/youtube-captions-scraper that referenced this issue Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants