fixed recaptcha race condition causing render errors #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we merge this please? |
|
Thanks @craig2017 👍 |
|
@craig2017 I also published a new version |
|
Thanks!
…On Mon, May 21, 2018, 5:33 AM Davide Papagni ***@***.***> wrote:
@craig2017 <https://github.com/craig2017> I also published a new version
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFA3yhFnagFH6sEL72SxwIHvNwgKpAQtks5t0on0gaJpZM4T0H_v>
.
|
|
Is there a way to have this fix on an older version? I can't upgrade my app to Ember 3.0+ so I'm stuck at |
|
I'm at ember 2.3 and it works fine.
…On Thu, May 24, 2018, 8:06 AM dguayrobotiq ***@***.***> wrote:
Is there a way to have this fix on an older version? I can't upgrade my
app to Ember 3.0+ so I'm stuck at ember-g-recaptcha 0.7.0
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFA3ylL2yWEdE56WlY8Ts_lc8HriYb96ks5t1qJagaJpZM4T0H_v>
.
|
|
@craig2017 I'm at ember |
|
I'm not sure. Try clearing your node modules.
It looks like the only change is mine plus a version update. The package
lock changed as well. Maybe delete that and do an npm install.
…On Thu, May 24, 2018, 8:42 AM dguayrobotiq ***@***.***> wrote:
@craig2017 <https://github.com/craig2017> I'm at ember 2.11.3 and when I
update to ember-g-recaptcha 0.9.0 I get this error:
Uncaught Error: Could not find module ***@***.***/object` imported from `ember-g-recaptcha/configuration`
at missingModule (loader.js:228)
at findModule (loader.js:239)
at Module.findDeps (loader.js:173)
at findModule (loader.js:243)
at Module.findDeps (loader.js:173)
at findModule (loader.js:243)
at requireModule (loader.js:26)
at resolveInitializer (index.js:5)
at registerInitializers (index.js:18)
at exports.default (index.js:44)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFA3ys05nPKazvzySnV4bb-8tRolaJtHks5t1qqogaJpZM4T0H_v>
.
|
|
I deleted
Also, it seems like the latest version ask for Maybe @algodave can chime in? |
|
That's probably just what he tested it on.
You should be good.
…On Thu, May 24, 2018, 9:36 AM dguayrobotiq ***@***.***> wrote:
I deleted node_modules and reinstalled and it worked. The only thing that
I worry about is the note in the release notes for version 0.8.0 here:
https://github.com/algonauti/ember-g-recaptcha/releases
Please note: This requires you app to be upgraded to Ember 3.0 or higher
Maybe @algodave <https://github.com/algodave> can chime in?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFA3yqCLqkOerZTO3mnXHhF-s3WKSMHJks5t1rdWgaJpZM4T0H_v>
.
|
|
@dguayrobotiq I can confirm that you should upgrade your project to Ember 3+ in order to have that fix - see discussion in #14 and #12 |
keanedawg
pushed a commit
to keanedawg/ember-g-recaptcha
that referenced
this pull request
Jan 21, 2021
updated copy right line, Chirs Bio and company logo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed recaptcha race condition causing render errors