Add option to skip recaptcha services in e2e env #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll be glad to improve this setup + testing more use cases, this was a |
|
This PR makes a HUGE difference in my use cases: before: after: |
|
Hey @brunoocasali Thanks for the PR. I'm planning to modernize the addon with latest JS syntax and to the latest LTS. I'll check your PR after and if everything is ok I'll merge. |
|
Hey @brunoocasali could you rebase your branch to master and fix the conflict and of course you need to use the skip option from args like @Skip |
|
Yeah I can do that! 👯 |
Merged
|
Closed, see #76 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@skipoption usage + normal usageCloses #52