Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure that all exception classes extend GoogleMapsJuice::ResponseError #7

Merged
merged 2 commits into from Jul 17, 2020
Merged

Make sure that all exception classes extend GoogleMapsJuice::ResponseError #7

merged 2 commits into from Jul 17, 2020

Conversation

alexmik95
Copy link
Contributor

Renamed GoogleMapsJuice::Error to GoogleMapsJuice::ResponseError which inherits RuntimeError. GoogleMapsJuice::ApiLimitError and GoogleMapsJuice::ZeroResults inherit GoogleMapsJuice::ResponseError.
Updated README section about Error Handling.

Alessio Micunco added 2 commits July 17, 2020 15:02
ResponseError inherits RuntimeError (+)
e82238f 
- ApiLimitError and ZeroResults inherit from ResponseError
- rename all occurrences
README: update Error Handling section
3e2c352
@alexmik95 alexmik95 requested a review from algodave July 17, 2020 13:09
@coveralls
Copy link

Pull Request Test Coverage Report for Build 40

  • 10 of 10 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 99.881%
Totals Coverage Status
Change from base Build 38: 0.0%
Covered Lines: 838
Relevant Lines: 839
💛 - Coveralls

@algodave
Copy link
Member

Thank you @alexmik95

@algodave algodave merged commit 50bc445 into master Jul 17, 2020
@alexmik95 alexmik95 deleted the exception-classes-extends-response-error branch July 17, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@algodave algodave Awaiting requested review from algodave

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexmik95 @coveralls @algodave