Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembler should track scratch slot types for better type checking #4035

Closed
jannotti opened this issue May 24, 2022 · 0 comments · Fixed by #4064
Closed

Assembler should track scratch slot types for better type checking #4035

jannotti opened this issue May 24, 2022 · 0 comments · Fixed by #4064
Assignees
Labels
new-feature-request Feature request that needs triage Team Scytale

Comments

@jannotti
Copy link
Contributor

The following program ought to report a type error at assembly time.

int 1
store 2
load 2
byte "hello"
concat

but it doesn't, because ProgramKnowledge only considers the stack, not scratch slots. But, along the path in a given basic block, knowledge about the types in scratch slows is just as trackable as the stack.

Such a treatment should also be aware that the scratch slots all begin with unit64(0) inside.

@jannotti jannotti added the new-feature-request Feature request that needs triage label May 24, 2022
@michaeldiamant michaeldiamant linked a pull request Jun 9, 2022 that will close this issue
@michaeldiamant michaeldiamant reopened this Jun 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new-feature-request Feature request that needs triage Team Scytale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants