Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error messages for DryRunInspector.from_single_response() #12

Merged
merged 2 commits into from May 3, 2022

Conversation

tzaffi
Copy link
Contributor

@tzaffi tzaffi commented May 3, 2022

First Real Unit Test

@algoidurovic pointed out the following confusing error that he encountered while using graviton for a test (cv. this pyteal commit):

require exactly 1 dry run transaction to create a singleton but had 0 instead

This PR will first check the existence of "error" in the dry-run response, and pass that through when encountered.

Additionally: Discarding the former sanity_test.py which was just a stub in favor or inspector_test.py

@algoidurovic algoidurovic self-requested a review May 3, 2022 18:09
@algoidurovic
Copy link

Was this tested with the commit you linked to? If so, what was the error message?

@tzaffi
Copy link
Contributor Author

tzaffi commented May 3, 2022

Was this tested with the commit you linked to? If so, what was the error message?

I ran the commit of pyteal referenced above, capturing this dryrun response that I then created the unit test out of.

@tzaffi tzaffi reopened this May 3, 2022
Copy link

@algoidurovic algoidurovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tzaffi tzaffi merged commit 9f4eac0 into main May 3, 2022
@tzaffi tzaffi deleted the better-error-message branch May 3, 2022 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants