Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using dry-run's cost #20

Closed
3 of 4 tasks
tzaffi opened this issue May 25, 2022 · 1 comment
Closed
3 of 4 tasks

Stop using dry-run's cost #20

tzaffi opened this issue May 25, 2022 · 1 comment
Assignees

Comments

@tzaffi
Copy link
Contributor

tzaffi commented May 25, 2022

Cost is Deprecated in go-algorand's Dry Run

As of go-algorand PR #3957 the dry run response transaction top-level-field cost is being deprecated. There is one usage of this field in non-deprecated graviton code.

The good news is that new better fields BudgetConsumed and BudgetAdded are being introduced in the same PR and that the cost can be calculated as

net cost = BudgetConsumed - BudgetAdded

Action items

  • go-algorand # 3957 is released
  • have a PR that replaces cost with the net cost formula above and stops referencing the original cost field
  • have a PR that allows accessing BudgetConsumed and BudgetAdded in the same way that cost is
  • PR's above have been merged and released
@michaeldiamant
Copy link
Contributor

Closing - https://github.com/algorand/graviton/releases/tag/v0.5.0 exists and algorand/pyteal#607 uses the functionality to implement OpUp tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants