Fewer results than are expected are returned when using limit

[epequeno]

When attempting to limit the number of results using limit the number of results are fewer than expected.

$ curl -s "localhost:8980/v2/accounts" | jq '.accounts|length'
4

$ curl -s "localhost:8980/v2/accounts?limit=1" | jq '.accounts|length'
0

$ curl -s "localhost:8980/v2/accounts?limit=2" | jq '.accounts|length'
1

In this example there are 4 total accounts. I would expect that a request to limit results to 1 should return an array of length 1.

I've tried to reset and update the environment as suggested on discord. This issue is present in the version noted here:

$ ./sandbox down

Stopping sandbox containers...
Stopping algorand-sandbox-indexer  ... done
Stopping algorand-sandbox-algod    ... done
Stopping algorand-sandbox-postgres ... done

$ ./sandbox clean

Cleaning up sandbox environment...

$ docker system prune -a
...
Total reclaimed space: 1.954GB

$ docker ps
CONTAINER ID   IMAGE     COMMAND   CREATED   STATUS    PORTS     NAMES

 $ git rev-parse HEAD
2e172b792a8b3fbb0952e5a7d34073bd44279f31

$ ./sandbox up

Starting default sandbox: release
see sandbox.log for detailed progress, or use -v.
* started!

algod version
8590327808
2.6.0.stable [rel/stable] (commit #8fe22d4e)
go-algorand is licensed with AGPLv3.0
source code available at https://github.com/algorand/go-algorand

Indexer version
2.4.0 compiled at 2021-05-31T22:24:40+0000 from git hash baa014ff63c6638074a04fcea32d4ce647b0dbb8 (modified)

Postgres version
postgres (PostgreSQL) 13.3

[yaovi-a]

Need to reproduce.

[winder]

Thank you for reporting this issue.

It looks like this was fixed at some point in the last 10 months. Tested just now with a fresh sandbox private network and the number of results is equal to the limit.

That said, there are some scenarios where the limit will act as an upper bound and not an exact result set size. For example, the recent "inner transaction" feature causes duplicate results to be returned in some cases. The duplicates are filtered out in most cases but were still counted towards the limit.