Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: removing hardcoded env var loading for localnet #66

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

aorumbayev
Copy link
Contributor

@aorumbayev aorumbayev commented Apr 9, 2024

Proposed Changes

  • Remove a hotfix that was addressing outdated readme instructions to allow executing smart contracts module for deploy directly without using algokit project deploy. Later PRs improved the docs and direct running deploy directly is not longer incentivized by the quick start guide hence instead of always loading the .env.localnet - its left as a comment for more advanced users.
  • Hotfix behaviour was invalid as it was clashing with other env vars. @CiottiGiorgio reported that due to this statement, deploying to any other custom network would clash since by default we don't specify empty env vars for things like PORT, Token and etc for testnet/mainnet nodely api access (while hardcoded load of localnet would set localnet specific values that would clash).

@aorumbayev aorumbayev merged commit 8a623ee into main Apr 9, 2024
1 check passed
@aorumbayev aorumbayev deleted the chore/remove_hotfix branch April 9, 2024 11:35
@CiottiGiorgio
Copy link
Member

Thanks team

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants