Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "zero value" with "not set" #454

Closed

Conversation

ivnsch
Copy link
Contributor

@ivnsch ivnsch commented Jun 30, 2021

https://developer.algorand.org/docs/reference/transactions/#asset-configuration-transaction

ConfigAsset
For re-configure or destroy transactions, this is the unique asset ID. On asset creation, the ID is set to zero.

Although in the required column it says "required, except on create", the mention of "zero" here is confusing and might lead people to setting a literal 0 as id, which makes the transaction fail.

@ivnsch
Copy link
Contributor Author

ivnsch commented Jul 1, 2021

Note: at least the Java SDK relies on the encoder to drop keys for "default" values (like 0 for integers), so if someone wants to confirm with the SDKs please inspect the final JSON (corresponding to the message pack encoding).

Copy link
Contributor

@barnjamin barnjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the PR! Looks good, but needs to be updated against the new version of the site

@barnjamin barnjamin closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants