Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Coconut compilation #949

Merged
merged 5 commits into from
Dec 5, 2021

Conversation

Amaras
Copy link
Member

@Amaras Amaras commented Nov 28, 2021

No description provided.

@Amaras Amaras self-assigned this Nov 28, 2021
@ShadowMitia ShadowMitia added the lang: coconut Coconut programming language label Nov 29, 2021
Copy link
Contributor

@ShadowMitia ShadowMitia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, and tested on the latest Docker and works fine.
The only thing I would discuss is maybe using a more recent version of python?
3.10 is already out. I tested with 3.9 it seems to work fine. Is there a reason to use 3.8?
I'm not sure what's the best practice is with coconut.

@Amaras
Copy link
Member Author

Amaras commented Dec 5, 2021

The only thing I would discuss is maybe using a more recent version of python? 3.10 is already out. I tested with 3.9 it seems to work fine. Is there a reason to use 3.8? I'm not sure what's the best practice is with coconut.

Since we target for 3.8+, it will work for 3.9 and 3.10 no problem.
The best practice would be to have universal code. However, since I sometimes use Python 3.8 syntax, compilation for (at least) 3.8 is needed.
If we get to it, we can bump the target version to 3.9 or 3.10.
We probably also need to have the --strict option, but I think some don't compile with this flag, so this should be a separate PR.

@Amaras Amaras merged commit b7568f5 into algorithm-archivists:main Dec 5, 2021
@Amaras Amaras deleted the coconut_compilation branch December 5, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: coconut Coconut programming language
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants