Bug fix in Array2dTracer _notify () #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
64json
added a commit
that referenced
this pull request
Jul 24, 2018
Bug fix in Array2dTracer _notify ()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, check out this scratch
When I use _notify () function on 2D Array Tracer with 3rd argument (v) as 0, the value in tracer is not updated even though 0 is a perfectly valid value.
This is because line 133 of array2d.js says:
This disqualifies 0, and doesn't allow us to set it as any item's value. We need to dis-allow all false-equivalent values apart from 0.
I think we should even allow null, but I haven't fixed for that, only for 0.
The result is as expected on my ghpages