-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker aliases #74
base: master
Are you sure you want to change the base?
Docker aliases #74
Conversation
@deardooley: Thank you for your contribution. This PR looks like a gem. I am sorry for answering so late and I hope you are still interested to help us with this. I wanted to create aliases for |
That works. My only concern is consistency with all the docker compose aliases. Would those become doc? If so, I’m wondering if there would be unintentional conflicts.
—
Rion
On Feb 4, 2018, at 2:44 AM, Cosmin M. Tutunaru <notifications@github.com<mailto:notifications@github.com>> wrote:
@deardooley<https://github.com/deardooley>: Thank you for your contribution. This PR looks like a gem. I am sorry for answering so late and I hope you are still interested to help us with this.
I wanted to create aliases for docker myself, but once I see how good this PR is, there is no reason for me to do it. I only have one question before merging this PR. What do you think about prefixing all commands/functions with do instead of d? Just for an easier way to manage name conflicts in the future between aliases.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#74 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAv7Mg7_L_vwA2RU4i6vMUqno7FAVoYfks5tRW3UgaJpZM4MMJy4>.
|
Thanks for your prompt response Rion. I understand your concerns and we have to find a solution for that. What do you think about treating |
Hey @deardooley, I hope you are doing great. Do you have any thoughts about my suggestion? I would like to merge this PR, and I don't know what is best. |
I think your suggestion makes sense. I already alias docker-compose as On a related note, I included a handful of functions in my PR. Are those appropriate to include given that the project name is "dotaliases?" |
It would be great if you can update this PR and move to a dedicated file the I know that the repository's name doesn't make functions appropriate, but I think we can't live without them :)) There are already several functions and I plan to add some more, so I don't find any problems to keep them. |
Hey @deardooley. Any thoughts? |
This PR contains several aliases and functions that make working with Docker more manageable.