Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker aliases #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Docker aliases #74

wants to merge 1 commit into from

Conversation

deardooley
Copy link

This PR contains several aliases and functions that make working with Docker more manageable.

@stocarul
Copy link
Collaborator

stocarul commented Feb 4, 2018

@deardooley: Thank you for your contribution. This PR looks like a gem. I am sorry for answering so late and I hope you are still interested to help us with this.

I wanted to create aliases for docker myself, but once I see how good this PR is, there is no reason for me to do it. I only have one question before merging this PR. What do you think about prefixing all commands/functions with do instead of d? Just for an easier way to manage name conflicts in the future between aliases.

@deardooley
Copy link
Author

deardooley commented Feb 4, 2018 via email

@stocarul
Copy link
Collaborator

stocarul commented Feb 4, 2018

Thanks for your prompt response Rion. I understand your concerns and we have to find a solution for that. What do you think about treating docker and docker-composer as different tools (somehow they are)? All docker aliases would start with do and all docker-composer aliases would start with dc. Of course, if we are going to do it this way, we would need to create different files for docker and docker-composer. Please let me know what you think. Have a great weekend!

@stocarul
Copy link
Collaborator

Hey @deardooley,

I hope you are doing great. Do you have any thoughts about my suggestion? I would like to merge this PR, and I don't know what is best.

@deardooley
Copy link
Author

I think your suggestion makes sense. I already alias docker-compose as dc. Aliasing docker as do seems to be fine and it fits with the existing naming scheme. Might as well throw in the docker-machine aliases as well. The only issue I personally have using do vs d is that it conflicts with a couple commands from obscure academic software packages I use. It is not likely that the alias base would be an issue for the majority of people using this repo.

On a related note, I included a handful of functions in my PR. Are those appropriate to include given that the project name is "dotaliases?"

@stocarul
Copy link
Collaborator

It would be great if you can update this PR and move to a dedicated file the docker-compose. Of course, you can also add some docker-machine aliases as well.

I know that the repository's name doesn't make functions appropriate, but I think we can't live without them :)) There are already several functions and I plan to add some more, so I don't find any problems to keep them.

@stocarul
Copy link
Collaborator

Hey @deardooley. Any thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants