added onTap event #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @rodrigorafaeldamaceno |
|
Your pr looks good so far, did you check if |
|
Good, I'm not familiar with swift and don't seen this for iOS, but it would be nice, I will try to do |
|
Ok, next week, I could also check iOS @rodrigorafaeldamaceno |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, thanks for this package, it has helped me a lot.
I had some problems implementing an onTap function, using gestures, so I realized that AndroidPdfViewer has support for this function, I just made the MethodChannel, android only.
You don't need to approve this PR, but it would be nice to bring this feature in new versions.