New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Objects are passed to iconv causing a warning #10

Closed

alhoqbani opened this issue Jul 9, 2017 · 0 comments

Labels

bug class: Arabic class: Date

Owner

alhoqbani commented Jul 9, 2017

Some methods calls, for example, setMode on the Date class will throw a warning causing the test to fail.

This is because setMode is returning the object which is passed to iconv as the third parameters.

For now, iconv should be wrapped on an if statement to be called when the value is string.

alhoqbani added bug class: Arabic class: Date labels

alhoqbani closed this as completed in

alhoqbani added a commit that referenced this issue


          Add is_numeric to check value passed to iconv #10

04f9cd7

This was referenced Jul 11, 2017

Method setArrFields is not getting params. #19

Closed

Booleans are not passed to the methods. #30

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment