Replace from.std with bare import statements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`from.std` pulls in the complete standard library. This is an issue for projects targeting webassembly because the standard library is not compatible with it.
aliak00
approved these changes
Nov 21, 2019
|
PS: Released as a minor version, so everything should work (without bumping optional) if you add bolts 1.3.1 as a hard dependency |
|
Perfect! Will try tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from.stdpulls in the complete standard library. This is an issuefor projects targeting webassembly because the standard library is
not compatible with it.
After merging this could you be so kind to make a (beta) release in the next few days, as well as to bump the optional package? Much appreciated.