Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old libtorrent & OpenSSL #9

Closed
ArcticGems opened this issue Mar 1, 2021 · 3 comments
Closed

Old libtorrent & OpenSSL #9

ArcticGems opened this issue Mar 1, 2021 · 3 comments

Comments

@ArcticGems
Copy link

ArcticGems commented Mar 1, 2021

Maybe I misunderstood your source code, but why are you using very old versions(3+ years) of Libtorrent & OpenSSL?

Maybe there is a good reason for it?

I recommend that you atleast update OpenSSL (to version 1.1.1j) for security and privacy reasons. 😄

@aliakseis
Copy link
Owner

aliakseis commented Mar 6, 2021

Hi,

Considering the old openssl version - yes it is my fault.
Talking about LibTorrent. I had experimented with the qbittorrent code in 2013. Its UI seemed to me rather slowly responding back then. I learned that it was because of the way the app enquires the items data. Prototyping of the callback usage for the state change notifications to the UI thread showed better results. Unfortunately it had turned out later that the callback usage is not the preferred way for interacting with the libtorrent library. For example I had to do this change to make things work:
e08445b#diff-1460769c1aaecf8e2f819a3d1c827620b822ca2d9b6505b30cf8ba2e1febeae1
Some of the functionality I relied on had become obsolete over time. So for the time being I decided to freeze an 1.1 version I had no problems with.

@ArcticGems
Copy link
Author

OK! 😄

Looking forward to LIII's OpenSSL update!

Good work 👍

@aliakseis
Copy link
Owner

Seems to be OK now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants