fix: Update to setting env variable #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`set-env` is deprecated due to a security vulnerability. https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/ Updated to the new way of setting env variables as describe in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files
|
Thanks a lot I will put a note in the course. Did you test the new one and made sure it is working properly? |
|
ah sorry didn't see your second comment :D Thanks! |
|
Correct me if I am wrong but it echoes an empty string in your logs right? I think it should be like this: |
|
Ah yes you're right, I don't know where I got those from 😅 I have committed the fix. Please see this now working: https://github.com/tombrowndev/github-actions-react-app/runs/1472961652?check_suite_focus=true |
|
Great! Thanks a lot I will merge it and also link to it in a note in the course :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set-envis deprecated due to a security vulnerability. https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/Updated to the new way of setting env variables as describe in https://docs.github.com/en/free-pro-team@latest/actions/reference/workflow-commands-for-github-actions#environment-files