iOS, macOS, and js support #23

luca992 · 2022-08-09T06:06:28Z

This is a draft and not finished yet. But, I have begun adding support for iOS, macOS, and js targets!

Use moko-resources to load common resources

use coroutines core in commonMain

For some reason composeable lambda functions on native macos throw an error and cause the application to crash. work around the issue by making result of composable lambdas non-null with the use of kotlin result

luca992 · 2022-08-10T07:06:53Z

still need rework findFetcherFor and findDecoderFor to work properly on native.... but I got it running on a macosArm64 native application 🎉

cool thing to note. The compose-ui native sample app is way smoother and kamel loads images faster on mac vs jvm

Screen.Recording.2022-08-10.at.2.58.43.AM.mov

mapInput does not work on native. On native, you cannot catch the error when calling map with the wrong input type. Rework by passing the kclass to mapInput Store mappers in map of KClass to Mapper Also in the mapper interface add inputKClass and outputKClass. inputKClass is used to store a mapper in the new mappers (KClass to Mapper) map in KamelConfigBuilder

fix bitmap decoder import for android

just like in `Mapper`, in `Fetcher` store `inputDataKClass` for the input data class of each `Fetcher` and in `Decoder` store the class of the output of the decoder in `outputKClass` use these to pick a suitable fetcher in findFetcherFor and a suitable decoder in findDecoderFor

it hides the ExperimentalKamelApi opt in requirement

Load file resources with moko-resources

There was an import error on jvm Also add moko-resources test dependency and expose it as well

https://youtrack.jetbrains.com/issue/IDEA-280006/Improve-Android-plugin-merging-cadence JetBrains/compose-multiplatform#2238

codestyles are set to kotlin official https://kotlinlang.org/docs/code-style-migration-guide.html

luca992 · 2023-05-08T00:23:42Z

@alialbaali finished everything I wanted to do 🎉. I know you said you gave me permission to merge. But did you want to take a look first?

kamel-core/src/commonMain/kotlin/io/kamel/core/utils/Platform.kt

alialbaali · 2023-05-08T02:09:08Z

Astonishing work you've done there! Thank you, really appreciated! 🎉🎉🎉

I don't have any issues at all, just a couple of things:

Did it ever occur to you to change the function name lazyPainterResource, because I don't think "lazy" means what it means in this context or function. It's been bugging me for a while 🥲
How do we go about publishing? Last time I tried to publish it, I couldn't get it to work in my other multiplatform project, even though it shows here, so I had to downgrade to 0.3.0. IIRC, it had something to do with the newer version of Kotlin.
Since I'm not going to be maintaining this project anymore, do you have any ideas on how things could move forward? Would you like to keep working on it? Maybe through a fork, or by just changing the dependency name? Or Should I make this repository part of an organization?

I personally don't mind, so please let me know your thoughts. 🙂

luca992 · 2023-05-08T02:29:29Z

@alialbaali

Honestly a lot of the names confuse me in general so I just didn't think about it and accepted it for what it was haha. You probably are right.
Really? Publishing has been working fine for me. I might have fixed some bugs though along the way. So maybe it will work as it should now for you as well. I just published again here with the latest:

implementation("io.github.luca992.com.alialbaali.kamel:kamel-image:0.5-darwinandjs4")

I'm down to maintain it. I don't know of any other image loading libraries for compose-multiplatform yet... so this is something I need haha. An organization might work well that way I can tag you in questions if you want to review prs occasionally. One thing you could do if you want to keep publishing under your name would be to setup a release branch which triggers a CI job to publish whenever a PR is merged into it.

alialbaali · 2023-05-08T03:06:23Z

Makes sense, haha 🥲. Feel free to change the names to whatever suitable maybe in another PR, or discussion. Even the name of the repository if you have something better in mind 😝
Well, that's good to hear!
The thing is, I don't prefer to keep publishing under my name when I'm not really doing any of the work right now. It seems unfair. So, I'm thinking of moving this repo to an organization, buy a domain name, and publish it under that domain. Maybe something like media.kamel:kamel-image:1.0.0. What do you think?

fix moko-resources missed actual declaration

luca992 · 2023-05-08T16:03:33Z

3. The thing is, I don't prefer to keep publishing under my name when I'm not really doing any of the work right now. It seems unfair. So, I'm thinking of moving this repo to an organization, buy a domain name, and publish it under that domain. Maybe something like `media.kamel:kamel-image:1.0.0`. What do you think?

that works 👍

alialbaali · 2023-05-08T16:28:10Z

Alright then.

Do you want to stick with the name Kamel? If so, what domain would you like us use?

So far, I found these two:

Kamel.media
Kamel.run

luca992 · 2023-05-08T16:40:01Z

I'd probably choose media if it were me. But your choice haha. And I think kamel is a solid name

alialbaali · 2023-05-10T21:35:00Z

Alright. So, I got the domain, and the repository has been transferred to an organization.

I'm guessing we're going to keep publishing on Maven Central, correct? If so, I think we might need a separate Sonatype Jira account where we can share the credentials? Or is it possible to invite someone to the project?

alialbaali · 2023-05-16T22:15:54Z

Any thoughts @luca992?

luca992 · 2023-05-17T00:52:28Z

Alright. So, I got the domain, and the repository has been transferred to an organization.

I'm guessing we're going to keep publishing on Maven Central, correct? If so, I think we might need a separate Sonatype Jira account where we can share the credentials? Or is it possible to invite someone to the project?

I don't think there's really any other viable option besides Maven Central anymore. And if you want to share credentials that's fine. You could make a bitwarden organization if you wanted to do that. But there's no way there's not a way to give multiple accounts permission to release to maven central for an organization.... however I have no idea how that works. Sonatype Jira is so confusing 🙃 maybe you can ask in the same ticket you use to create the new repository?

alialbaali · 2023-05-17T21:14:34Z

I just need your Sonatype username, so I can let you publish artifacts. @luca992

alialbaali · 2023-05-17T21:43:38Z

Alright, I messaged you.

iadcialim · 2023-07-18T09:31:55Z

Thank you guys for this great library! Curious if there is significant change in the usage/documentation?

luca992 · 2023-07-18T19:56:43Z

Thank you guys for this great library! Curious if there is significant change in the usage/documentation?

There shouldn't have been from this pr. The main README.md should be upto date

luca992 added 8 commits August 8, 2022 20:27

fix build

629ecac

Update kotlin to 1.7.10 and other dependencies. Cleanup unused

d01f281

setup project for native darwin targets.

43f9dae

Use moko-resources to load common resources

Add a macOs native application sample

23a2143

fix coroutines dependencies

41b9bda

use coroutines core in commonMain

remove essentially what is essentially a duplicate function

d5dce9c

workaround compose issue for darwin: lambda w/ null return throws error

dbdf4d4

For some reason composeable lambda functions on native macos throw an error and cause the application to crash. work around the issue by making result of composable lambdas non-null with the use of kotlin result

suppress gradle build warning

faed3c0

luca992 added 11 commits August 10, 2022 17:12

Implement bitmap decoder for non-jvm

43179b5

fix bitmap decoder import for android

add back removed "duplicate" lazyPainterResource

54cd491

it hides the ExperimentalKamelApi opt in requirement

fix adding moko resources to native app bundle in native desktop sample

1e6774a

Switch between file and gallery samples on macos. load file using MR

bda67f5

Load file resources with moko-resources

expose moko-rosources to kamel-samples

9a83662

There was an import error on jvm Also add moko-resources test dependency and expose it as well

use java 11 everywhere. gradle cleanup and add todo notes

e3b58c0

update compose-jb

fd6bf40

update gradle

a856877

AGP to 7.3.0-rc01 (Must use android studio, see notes), remove todos

3f1d7fc

https://youtrack.jetbrains.com/issue/IDEA-280006/Improve-Android-plugin-merging-cadence JetBrains/compose-multiplatform#2238

luca992 force-pushed the darwin branch from 2a0532e to 3f1d7fc Compare September 13, 2022 02:41

luca992 added 8 commits September 12, 2022 22:53

add iosSimulatorArm64 target

c6f5755

ignore all build folders properly. do not ignore codestyles

a448c2e

codestyles are set to kotlin official https://kotlinlang.org/docs/code-style-migration-guide.html

remove unused repos

8027009

convert to suspend fun

550f110

add js web support!

26c5fe8

cleanup/refactor

6c152bf

implement MappersUtils for js. move HttpFetcherTest to common.

c7cc393

Merge branch 'js' into darwin

7b797e9

luca992 changed the title ~~iOS and macOS support~~ iOS, macOS, and js support Sep 13, 2022

luca992 added 3 commits May 7, 2023 19:52

fix warnings

220a539

another moko-resources gradle task dependency fix

8f4b047

warning fix

0ffd67b

luca992 marked this pull request as ready for review May 8, 2023 00:21

Don't apply mokoResources to kamel-core

2aeeb1e

alialbaali reviewed May 8, 2023

View reviewed changes

kamel-core/src/commonMain/kotlin/io/kamel/core/utils/Platform.kt Outdated Show resolved Hide resolved

Dispatchers.kamel -> Dispatchers.Kamel

1cb670c

Alex009 and others added 4 commits May 8, 2023 20:29

fix actual declaration not found in generated dir

ebaac38

Merge pull request #1 from Alex009/moko22

64aabeb

fix moko-resources missed actual declaration

Merge branch 'moko22' into darwin

4bf75f7

remove moko-resources task dependency workaround

bccbe5f

luca992 added 4 commits May 19, 2023 14:22

update publishing info

1fee4d4

update readme

9f8a514

fix readme dependency

3563f38

fix badges. v0.5.0

398e9bf

luca992 merged commit 19f8fac into Kamel-Media:main May 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

iOS, macOS, and js support #23

iOS, macOS, and js support #23

luca992 commented Aug 9, 2022 •

edited

Loading

luca992 commented Aug 10, 2022 •

edited

Loading

luca992 commented May 8, 2023

alialbaali commented May 8, 2023 •

edited

Loading

luca992 commented May 8, 2023 •

edited

Loading

alialbaali commented May 8, 2023

luca992 commented May 8, 2023

alialbaali commented May 8, 2023

luca992 commented May 8, 2023

alialbaali commented May 10, 2023

alialbaali commented May 16, 2023

luca992 commented May 17, 2023

alialbaali commented May 17, 2023

alialbaali commented May 17, 2023

iadcialim commented Jul 18, 2023

luca992 commented Jul 18, 2023

iOS, macOS, and js support #23

iOS, macOS, and js support #23

Conversation

luca992 commented Aug 9, 2022 • edited Loading

luca992 commented Aug 10, 2022 • edited Loading

luca992 commented May 8, 2023

alialbaali commented May 8, 2023 • edited Loading

luca992 commented May 8, 2023 • edited Loading

alialbaali commented May 8, 2023

luca992 commented May 8, 2023

alialbaali commented May 8, 2023

luca992 commented May 8, 2023

alialbaali commented May 10, 2023

alialbaali commented May 16, 2023

luca992 commented May 17, 2023

alialbaali commented May 17, 2023

alialbaali commented May 17, 2023

iadcialim commented Jul 18, 2023

luca992 commented Jul 18, 2023

luca992 commented Aug 9, 2022 •

edited

Loading

luca992 commented Aug 10, 2022 •

edited

Loading

alialbaali commented May 8, 2023 •

edited

Loading

luca992 commented May 8, 2023 •

edited

Loading