Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce text brightness in reading mode #124

Closed
Tracked by #90
AI-IMED opened this issue Aug 28, 2022 · 11 comments
Closed
Tracked by #90

Reduce text brightness in reading mode #124

AI-IMED opened this issue Aug 28, 2022 · 11 comments
Labels
enhancement New feature or request
Milestone

Comments

@AI-IMED
Copy link

AI-IMED commented Aug 28, 2022

I hope the text brightness is reduced in reading mode, for the comfort of the eyes

Screenshot_٢٠٢٢٠٨٢٨_١٠١٨٣١

@alialbaali alialbaali added the enhancement New feature or request label Aug 28, 2022
@alialbaali alialbaali added this to the 2.2.0 milestone Aug 28, 2022
@alialbaali alialbaali mentioned this issue Aug 28, 2022
43 tasks
@alialbaali
Copy link
Owner

Do you think there should be an option to choose dim amount, with a slider?

@AI-IMED
Copy link
Author

AI-IMED commented Aug 28, 2022

If this will include the editing mode as well, I think that having the option will be useful, but if the matter will be limited to the reading mode, I prefer that you adjust the brightness value that you see fit and comfortable for reading yourself, without the need to add an option

@AI-IMED
Copy link
Author

AI-IMED commented Sep 12, 2022

v2.2.0-Beta2
The dim level is very high for me, I don't see anything when I'm in a bright place especially when I use the dark and black theme, the idea of ​​having a bar to control the opacity level seems really useful.

@alialbaali
Copy link
Owner

Would you prefer a few modes such as (Low, Mid, High), or a complete brightness bar?

@AI-IMED
Copy link
Author

AI-IMED commented Sep 12, 2022

I think the bar is better, because it allows more flexibility in controlling the amount of brightness

@alialbaali
Copy link
Owner

alialbaali commented Sep 12, 2022

Both can be shown as bars. It's just about the amount of options available. One is just like the bar in your device that controls the brightness, and the other provides 3 to 5 options in a bar or a dialog, such as (Min, Very Low, Low, Medium, High, Very High, Max, Default).

@AI-IMED
Copy link
Author

AI-IMED commented Sep 13, 2022

If you mean a bar that looks like a control bar for the number of lines in the previews, with numbers replaced with the names of the options in the dialog boxes and without skipping some values ​​between each two options, this is fine, and if indeed there will be some values ​​ignored between each two options, then the full brightness bar will certainly be better

I was thinking instead of all that, with a gesture that takes advantage of the part shown in the picture, this way the control is faster and easi

Screenshot_٢٠٢٢٠٩١٣_٠٧٤٥٣٩

@alialbaali
Copy link
Owner

I don't agree with adding a bar in Reading Mode, due to these reasons:

  1. It would replicate the same bar in the Notification Panel.
  2. It would be enabled always.
  3. The placement you have provided isn't the best UX/UI.

I personally prefer to have quick options available to the user, without messing with the UI much. This is what I came up with:
IMAGE 2022-09-13 14:29:38

There could be an option at the end, to set a custom value using the bar. Also, these options could also be modified from Reading Mode screen itself displayed as an icon.

@AI-IMED
Copy link
Author

AI-IMED commented Sep 13, 2022

Well, I have to wait, maybe the experience is better than I imagined

alialbaali added a commit that referenced this issue Sep 29, 2022
@alialbaali
Copy link
Owner

Any update?

@AI-IMED
Copy link
Author

AI-IMED commented Oct 13, 2022

It's okay. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants