Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smoothing out "Undo" #141

Closed
5 tasks done
Tracked by #190
uli-on opened this issue Sep 27, 2022 · 9 comments
Closed
5 tasks done
Tracked by #190

Smoothing out "Undo" #141

uli-on opened this issue Sep 27, 2022 · 9 comments
Labels
enhancement New feature or request
Milestone

Comments

@uli-on
Copy link

uli-on commented Sep 27, 2022

I am very grateful for having the possibility of using an undo feature in Noto and jump back and forth between versions. Nevertheless there are some edges about that feature set that might benefit from smoothing out. IMHO these are:

  • Reduce gap between buttons and keyboard and also flatten buttons a little, both eats up screen real estate important for writing and reading

  • don't record any letter change, e. g. only completed words, i. e. save on blanks or punctuation, respectively*

  • only show essential/changed areas in history. That way users can make their decisions easier because they can compare in history preview already. (The current situation is apt only for shorter notes*.)

  • make different entries in history distinguishable by displaying dividers or - probably more evident - by using zebra striped backgrounds like currently only used between last version and "global rest". The current version might then have a border to set it apart from the rest.

  • add a timestamp to each history entry (or numeratation) for easier orientation ("Am I seeing the most recent version or the oldest?")

*For opening this IMO medium sized text's history, edited in two Noto sessions (i.e. history steps halved), it certainly took far more than 10 sec, BTW, to stop scrolling (loading history) and let me choose,

@alialbaali alialbaali added the enhancement New feature or request label Sep 29, 2022
@alialbaali
Copy link
Owner

* don't record any letter change, e. g. only completed words, i. e. save on blanks or punctuation, respectively*

Do you think this effect should be only for the history dialog, or the whole undo/redo functionality?

@uli-on
Copy link
Author

uli-on commented Jan 29, 2023

If it is possible to separate the history dialogue from the undo button steps, then it'd be probably quite useful keeping the capability of undoing single letters. My main criterion was, after a while of typing, the dialogue becoming really unwieldy with the current respecting every single change of a letter, and opening the dialogue then takes verrrry much time.

@alialbaali
Copy link
Owner

Done.
Now, for the third point:

only show essential/changed areas in history. That way users can make their decisions easier because they can compare in history preview already. (The current situation is apt only for shorter notes*.)

What do you think would be better, show only differences and remove similarities, or keep them both and highlight changes, like in the image?

IMAGE 2023-02-07 23:57:35

@uli-on
Copy link
Author

uli-on commented Feb 8, 2023

The screenshot version would offer more context, so choosing would be easier. I imagine I'd have a longer text and jump through the text editing here and there and would only be presented single words. Nope.

But - cause you're leaving that point open - it needs to be excerpted! (Your screenie might be meant as representing the whole text.)

@alialbaali
Copy link
Owner

Version 2.2.1 has been released. I hope it resolved some of the issues you mentioned. Please let me know what more can be done. Thanks!

@uli-on
Copy link
Author

uli-on commented Mar 19, 2023

I'd gladly test these changes if the crashes (#170) let me do so.

@uli-on
Copy link
Author

uli-on commented Mar 28, 2023

This is now very usable, I've written a comparable portion of text as for the first post here and the history dialogue was open before I could lift my finger from the display :) Great!

The only thing that doesn't seem to be working properly is the coloured span that's indicating the last alterations, especially when not writing linearly from top to bottom but skipping back some paragraphs and amending words. There it happened that nothing was coloured at all. But still very helpful, that history view.

@alialbaali alialbaali mentioned this issue May 24, 2023
35 tasks
@alialbaali alialbaali added this to the 2.3.0 milestone May 24, 2023
@alialbaali
Copy link
Owner

alialbaali commented Jun 2, 2023

I believe the latest beta resolves all the issues regarding the first comment or list of tasks. For the colored span not working, please create another issue.

Thank you!

@uli-on
Copy link
Author

uli-on commented Jun 6, 2023

I'll close this, cause in my opinion these helper tools are now very useful and matured. Currently, I have no ideas what might be causing the loss of the coloured span when jumping back/upward in the text while editing, other than just this. Will keep my eyes open.

@uli-on uli-on closed this as completed Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants