Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search > Distance between Search field and toolbar/keyboard #198

Closed
Tracked by #190
uli-on opened this issue Jun 8, 2023 · 10 comments
Closed
Tracked by #190

Search > Distance between Search field and toolbar/keyboard #198

uli-on opened this issue Jun 8, 2023 · 10 comments
Labels
enhancement New feature or request
Milestone

Comments

@uli-on
Copy link

uli-on commented Jun 8, 2023

Like already mentioned in #73 (comment), there's currently a gap between the search input field and Noto's toolbar/the keyboard, respectively. This is wasted space on smaller devices, regretfully, but also lets whole lines of text flicker through these elements while scrolling or editing the text, which is distracting from writing.

Additionally, the search field makes it hard to differentiate it from the background when the theme is set to dark or black, as there's no shadow possible like in the light theme nor is there a border to indicate the search box's dimensions.

In the writing/searching-situation depicted in the screenshot below you have four stripes of text elements that have to be interpreted and told apart:

  • the main text
  • the search term (ein)
  • the -superfluous- line of text blinking through (Obgleich ihn […])
  • the text proposals on the keyboard's top bar (einer | eine | einem)

Solutions: See below image

Screenshot_20230608-181004

The changes that would save space and make it easier to keep track of what is what and not get distracted by flickering text would comprise of

  • eliminating the gap between the search field and Noto's toolbar/the keyboard
  • lighting up the search bar's background colour cautiously in order to make it distinguishable from the page's background
  • making the search bar full width in order to style it more appealing, now the gap is closed.
@alialbaali alialbaali added the enhancement New feature or request label Jun 8, 2023
@alialbaali alialbaali added this to the 2.3.0 milestone Jun 8, 2023
@alialbaali alialbaali mentioned this issue Jun 6, 2023
35 tasks
@alialbaali
Copy link
Owner

Thank you for creating the issue!

I've been trying to find a good way to redesign the search by relying on the pain points you have mentioned. However, I couldn't find an elegant way to do so. Meaning, I tried to remove the elevation, keep the elevation, change the background, combine the bottom toolbar with the search, but none of them worked well, or looked great.

So, I decided to move the search bar to the top, specifically, below the toolbar. Now, the only issue I see is that, it might be harder to reach, opposed to having the search bar at the bottom. On the positive side, moving the search bar to the top would result in having all the filtering "criteria" to be at the top along with labels. Also, most Android apps have the search bar at the top, which might be a good decision to move in this direction.

Here's a screenshot on how it might look (feedback is appreciated):

IMAGE 2023-06-09 22:33:54

@uli-on
Copy link
Author

uli-on commented Jun 10, 2023

All good and valid points to move the search field up. Plus: The search button is still within thumb's reach and the keyboard opens without moving hands, the cursor sitting in the necessary position. And the page is looking tidy. Would be interesting to see how an opened note is looking now.

@alialbaali
Copy link
Owner

Great to hear that! I'll go ahead an implement it.

@alialbaali
Copy link
Owner

Here's how Find in Note is going to look like:

IMAGE 2023-06-10 22:31:30
IMAGE 2023-06-10 22:31:33

Hope it resolves all the concerns you have addressed.

@uli-on
Copy link
Author

uli-on commented Jun 11, 2023

From the looks: Really nice! I would have to try scrolling and see whether the gap is opaque now or not. One grain of complaint though: there's still quite some non usable screen real estate between the search field and the label buttons, and it looks as if it's still around a line of text high.

@alialbaali
Copy link
Owner

The gap is actually necessary since the search bar remains visible when scrolling, and it needs to be elevated along with the top bar. If I remove the gap, it wouldn't look right.
IMAGE 2023-06-19 20:42:44

@uli-on
Copy link
Author

uli-on commented Jun 20, 2023

Ah, all right, I hadn't thought about the labels being taken to the top when scrolling, as I see now in your screenshot.

alialbaali added a commit that referenced this issue Jul 4, 2023
@alialbaali
Copy link
Owner

Any thoughts?

@uli-on
Copy link
Author

uli-on commented Jul 15, 2023

Looks good and organic, and - best of all - no more distracting text flickering through. Thanks!

@uli-on uli-on closed this as completed Jul 15, 2023
@alialbaali
Copy link
Owner

You're very welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants