Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilizing the Save to Noto shortcut crashes Noto #203

Closed
Tracked by #190
pgrilo opened this issue Jul 17, 2023 · 1 comment
Closed
Tracked by #190

Utilizing the Save to Noto shortcut crashes Noto #203

pgrilo opened this issue Jul 17, 2023 · 1 comment
Labels
bug Something isn't working
Milestone

Comments

@pgrilo
Copy link

pgrilo commented Jul 17, 2023

ISSUE

The Save to Noto shortcut consistently crashes Noto before a new note is created.

To reproduce:

  • Open any other app
  • Select some content
  • Action -> Share -> Save to Noto

LOG

Caused by:
java.lang.IllegalArgumentException:
Required argument "title" is missing and does not have an android:defaultValue
 at y6.h0.fromBundle(SourceFile:116)

SOLUTION

Add defaultValueand nullable to the selectFolderDialogFragment argument.

res/navigation/nav_graph.xml

<dialog
    android:id="@+id/selectFolderDialogFragment"
    android:name="com.noto.app.main.SelectFolderDialogFragment"
    android:label="SelectFolderDialogFragment">
    
(...)
    
    <argument
        android:name="title"
        android:defaultValue="@null"
        app:nullable="true"
        app:argType="string" />
</dialog>

Thank you

@pgrilo pgrilo changed the title Utilizing the **Save to Noto** shortcut crashes Noto Utilizing the Save to Noto shortcut crashes Noto Jul 17, 2023
@alialbaali alialbaali added the bug Something isn't working label Jul 20, 2023
@alialbaali alialbaali added this to the 2.3.0 milestone Jul 20, 2023
@alialbaali alialbaali mentioned this issue Jul 20, 2023
35 tasks
alialbaali added a commit that referenced this issue Jul 21, 2023
@alialbaali
Copy link
Owner

alialbaali commented Jul 29, 2023

This should be fixed in 2.3.0-Beta3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants