The Edit and Reorder Label options sheets fails to open

[pgrilo]

ISSUE

When the Label options bottomSheet is dismissed, since it is a navigation stack, everything on top of it is removed. As result the Edit and Reorder label bottomSheets fails to open.

To reproduce:

• Long press a Label
• Tap Edit or Reorder

LOG

DialogFragmentNavigator: 
Dialog LabelDialogFragment{d5a0bad} (7c5cafb0-d6b2-48d3-84bf-b55f13a396f1 tag=d5dac1c4-b811-4eec-97d8-14c2d7bfcbf4) 
was dismissed while it was not the top of the back stack, popping all dialogs above this dismissed dialog

SOLUTION

Remove dismiss() from the LabelDialogFragmentBinding.setupListeners function.

java/com/noto/app/label/LabelDialogFragment.kt

private fun LabelDialogFragmentBinding.setupListeners() {
    tvEditLabel.setOnClickListener {
        context?.updateAllWidgetsData()
        //dismiss()
        navController
            ?.navigateSafely(LabelDialogFragmentDirections.actionLabelDialogFragmentToNewLabelDialogFragment(args.folderId, args.labelId))
    }

    tvReorderLabel.setOnClickListener {
        context?.updateAllWidgetsData()
         //dismiss()
        navController
             ?.navigateSafely(LabelDialogFragmentDirections.actionLabelDialogFragmentToReorderLabelDialogFragment(args.folderId, args.labelId))
     }

And make use of popUpTo and popUpToInclusive on the navigate call.

res/navigation/nav_graph.xml

<dialog
    android:id="@+id/labelDialogFragment"
    android:name="com.noto.app.label.LabelDialogFragment"
    android:label="LabelDialogFragment">
    <action
        android:id="@+id/action_labelDialogFragment_to_newLabelDialogFragment"
        app:destination="@id/newLabelDialogFragment"
        app:popUpTo="@id/labelDialogFragment"
        app:popUpToInclusive="true" />

(...)

    <action
        android:id="@+id/action_labelDialogFragment_to_reorderLabelDialogFragment"
        app:destination="@id/reorderLabelDialogFragment"
        app:popUpTo="@id/labelDialogFragment"
        app:popUpToInclusive="true" />

(...)

</dialog>

Thank you

[uli-on]

Pheeeew, that one was the worst of all, and it's gone. Thank you soo much!

[alialbaali]

Thanks to @pgrilo, I used their solution! 🚀