Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

During multi-selection: Just holding a label changes its status. #206

Closed
Tracked by #190
uli-on opened this issue Jul 18, 2023 · 8 comments
Closed
Tracked by #190

During multi-selection: Just holding a label changes its status. #206

uli-on opened this issue Jul 18, 2023 · 8 comments
Labels
enhancement New feature or request
Milestone

Comments

@uli-on
Copy link

uli-on commented Jul 18, 2023

Just holding and subsequently sliding out of the label changes the label status. That's not expected and undesirable cause it can not be undone to the original state if the initial situation comprised notes of mixed labels and label status, and one of the only partially assigned labels was involved/held.

Noto v2.3.0-beta2
Fairphone 3
Android 10 with GMS updated to v23.13.12

@alialbaali
Copy link
Owner

Could you please provide a screenshot/screencast to help me understand the issue better?

@uli-on
Copy link
Author

uli-on commented Jul 20, 2023

The demo setup is two notes two labels. Each note has only one different label assigned.

I've switched on tap marks, so you can see when I touch and when I let go, and where.

ScreenRecording_20230720_235610.mp4

@alialbaali
Copy link
Owner

I see what you mean. That's basically long clicking on the label changes the status. If you think long clicking isn't helpful in this case, I could disable it.

@uli-on
Copy link
Author

uli-on commented Jul 23, 2023

That!

@alialbaali alialbaali added the enhancement New feature or request label Jul 23, 2023
@alialbaali alialbaali added this to the 2.3.0 milestone Jul 23, 2023
@alialbaali alialbaali mentioned this issue Jul 23, 2023
35 tasks
@alialbaali
Copy link
Owner

Done!

@uli-on
Copy link
Author

uli-on commented Jul 24, 2023

Thanks!

@alialbaali
Copy link
Owner

You’re welcome!

@uli-on
Copy link
Author

uli-on commented Jul 25, 2023

Fixed, hooray! That made hesitantly scrolling a plague.

@uli-on uli-on closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants