Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for MongoDB #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

neithere
Copy link

Addresses issue #80.

Changes:

  • Add package dependency. (Might be optional?)
  • Add option --use_mongodb to prefer that backend over Redis. (A mandatory --backend={mongodb|redis} might be better?)
  • Use defaults for theme and board size to prevent breaking UI with empty values. (Should be on a higher level but for some reason it works with Redis as is.)
  • Return cards as a list of hashes instead of hash of hashes.
  • Avoid shadowing incoming argument variables with values of a different type. (Ideally should be either extended to other functions for consistency or reverted if there's some reason for that like a JavaScript idiom.)

@Bisonfan95
Copy link

Hello Neit! Did your changes fix the MongoDB support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants