Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem associated with leap year #36

Open
MR-Mostafa opened this issue Jan 24, 2023 · 0 comments
Open

Problem associated with leap year #36

MR-Mostafa opened this issue Jan 24, 2023 · 0 comments

Comments

@MR-Mostafa
Copy link

MR-Mostafa commented Jan 24, 2023

Hi,
I found out that this library uses an incorrect method for calculating leap years,
As an example:
This library shows Esfand month 1403 as 29 days, which is actually a 30-day month.
Additionally, I checked the jalaali-js library and found that it is calculating leap years correctly.

Demo:
https://js-r3ebqv.stackblitz.io

Correct:
image

Note:

List of leap years (problem is with the leap before the five-year leap)
As an example, the year 1408 is a five-year leap, and the leap before this year is 1403. or the year 1441 is a five-year leap, and the leap before this year is 1436.
There is no support for five-year leap years in this plugin, and all leap years are based on four-year leap years.

KabiseShamsi1206-1498-new.pdf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant