Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem associated with leap year #54

Closed
MR-Mostafa opened this issue Jan 25, 2023 · 8 comments
Closed

Problem associated with leap year #54

MR-Mostafa opened this issue Jan 25, 2023 · 8 comments

Comments

@MR-Mostafa
Copy link

MR-Mostafa commented Jan 25, 2023

Hello
As you have used dayjs library and jalaliday plugin, do you know how to fix the issue in jalaliday plugin?

This Issue
alibaba-aero/jalaliday#36

@samsam-ahmadi
Copy link
Owner

Hey, @MR-Mostafa I think they are working on another project. https://github.com/zoomit-org/Dayjs-Jalali-Plugin
I will check it. if it works, I will replace it with the old one.

Thanks for informing me.

@MR-Mostafa
Copy link
Author

Hi @samsam-ahmadi,
Thank you for your response
This plugin also has the same problem based on my tests. There is already an issue that I have already announced.

@samsam-ahmadi
Copy link
Owner

@MR-Mostafa Would you please make it online so I can test it ? Cause I test it and didn't find any issues.

@MR-Mostafa
Copy link
Author

@amirhmoradi
Copy link

Hi @samsam-ahmadi
for the jalali (persian) calendar and maybe other calendar systems, you might consider using my dayjs plugin which shall fix the mentioned issue and is meant for a more global and clean calendar systems management:

https://github.com/calidy-com/dayjs-calendarsystems

It does correct conversions to and from persian calendar, and is compatible with .tz, .utc and other functions.

It uses standard dayjs api to manage calendar systems. please have a look and let me know if it is useful for you.

@samsam-ahmadi
Copy link
Owner

Hello @amirhmoradi, Thanks for your suggestion.
I will look at this and try to find the best option.

@samsam-ahmadi
Copy link
Owner

@MR-Mostafa If you have still the issue with it, I fixed that issue by replacing the jalaliday with https://github.com/zoomit-org/Dayjs-Jalali-Plugin.

Give me time to test and release it.

samsam-ahmadi pushed a commit that referenced this issue May 31, 2023
@samsam-ahmadi
Copy link
Owner

Hi @MR-Mostafa,

Fixed in V1.13.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants