This repository has been archived by the owner on Feb 8, 2023. It is now read-only.
feat: init stream to buffer #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popomore
reviewed
Feb 28, 2018
| done(); | ||
| } | ||
|
|
||
| function done() { |
There was a problem hiding this comment.
promise 只会 resolve 一次，这个多次调用也无所谓的
popomore
reviewed
Feb 28, 2018
index.js
Outdated
| function done() { | ||
| if (error) reject(error); | ||
| else resolve(Buffer.concat(bufs)); | ||
| cleanup(); |
Codecov Report
@@ Coverage Diff @@
## master #1 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 1
Lines ? 29
Branches ? 0
=======================================
Hits ? 29
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
dead-horse
commented
Feb 28, 2018
| } | ||
|
|
||
| function done() { | ||
| cleanup(); |
There was a problem hiding this comment.
额，这个还不能放前面，bufs 被清空了。问题不大，反正都是同步的。
fengmk2
reviewed
Feb 28, 2018
index.js
Outdated
| } | ||
|
|
||
| function cleanup() { | ||
| bufs = []; |
fengmk2
reviewed
Feb 28, 2018
index.js
Outdated
|
|
||
| function cleanup() { | ||
| bufs = []; | ||
| error = null; |
fengmk2
reviewed
Feb 28, 2018
| "name": "stream-to-buf", | ||
| "description": "convert stream to buffer", | ||
| "version": "1.0.0", | ||
| "homepage": "https://github.com/node-modules/stream-to-buf", |
fengmk2
approved these changes
Feb 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.