Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Radio): fix radio group preview #1391

Merged
merged 5 commits into from
Nov 27, 2019
Merged

fix(Radio): fix radio group preview #1391

merged 5 commits into from
Nov 27, 2019

Conversation

byeval
Copy link
Contributor

@byeval byeval commented Nov 27, 2019

  • checkbox group preview use label & children
  • radio group preview use label & children

@codecov
Copy link

codecov bot commented Nov 27, 2019

Codecov Report

Merging #1391 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1391      +/-   ##
==========================================
+ Coverage   90.04%   90.04%   +<.01%     
==========================================
  Files         270      270              
  Lines       15191    15205      +14     
  Branches     4922     4928       +6     
==========================================
+ Hits        13678    13692      +14     
  Misses       1487     1487              
  Partials       26       26
Impacted Files Coverage Δ
src/radio/radio-group.jsx 97.1% <100%> (+0.32%) ⬆️
src/checkbox/checkbox-group.jsx 95.71% <100%> (+0.55%) ⬆️
src/tab/tabs/nav.jsx 91.66% <0%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6e6171...9ca45fc. Read the comment docs.

@youluna youluna merged commit e993cdb into alibaba-fusion:master Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants