Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat shell fixed #1738

Merged
merged 4 commits into from Apr 3, 2020
Merged

Feat shell fixed #1738

merged 4 commits into from Apr 3, 2020

Conversation

youluna
Copy link
Member

@youluna youluna commented Apr 1, 2020

No description provided.

@youluna youluna changed the base branch from master to feat-life-cycle April 1, 2020 14:27
@codecov
Copy link

codecov bot commented Apr 1, 2020

Codecov Report

Merging #1738 into feat-life-cycle will increase coverage by 0.05%.
The diff coverage is 85.10%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           feat-life-cycle    #1738      +/-   ##
===================================================
+ Coverage            90.03%   90.08%   +0.05%     
===================================================
  Files                  275      275              
  Lines                15641    15881     +240     
  Branches              5099     5189      +90     
===================================================
+ Hits                 14082    14307     +225     
- Misses                1532     1547      +15     
  Partials                27       27              
Impacted Files Coverage Δ
src/shell/shell.jsx 82.88% <84.44%> (+0.16%) ⬆️
src/shell/base.jsx 90.00% <100.00%> (-1.67%) ⬇️
src/util/dom.js 82.40% <100.00%> (ø)
src/table/virtual/body.jsx 74.19% <0.00%> (-2.28%) ⬇️
src/table/base/wrapper.jsx 100.00% <0.00%> (ø)
src/table/fixed/header.jsx 100.00% <0.00%> (ø)
src/table/lock.jsx 86.30% <0.00%> (+0.59%) ⬆️
src/input/input.jsx 95.91% <0.00%> (+1.97%) ⬆️
src/table/base.jsx 94.98% <0.00%> (+2.12%) ⬆️
src/table/fixed/body.jsx 66.66% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc9ef09...6c4feac. Read the comment docs.

@youluna youluna merged commit 0b674b6 into feat-life-cycle Apr 3, 2020
@youluna youluna deleted the feat-shell-fixed branch April 3, 2020 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant