Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Checkbox] Checkbox的value类型，应该包含boolean #3931

Closed
cwtuan opened this issue May 31, 2022 · 2 comments · Fixed by #4519 or #4528
Closed

[Checkbox] Checkbox的value类型，应该包含boolean #3931

cwtuan opened this issue May 31, 2022 · 2 comments · Fixed by #4519 or #4528
Assignees
@YunMeng99
Labels
improvement improve some features Next release issues to close in next release

Comments

@cwtuan
Copy link
Contributor

cwtuan commented May 31, 2022

Component

Checkbox

Steps to reproduce

Checkbox定义文件有问题
image

Checkbox的value类型，应该包含boolean

目前ts定义不支持boolean：
image

在types定义成了：
image
@fusion-design-bot fusion-design-bot self-assigned this May 31, 2022
@youluna
Copy link
Member

youluna commented Jun 1, 2022

你的场景下用checked是不是更合适？

checkbox设计上是想把value 和 checked 分开

@jun599 jun599 mentioned this issue Mar 23, 2023
Closed
@cwtuan
Copy link
Contributor Author

cwtuan commented Mar 28, 2023

一个form底下，有多个item，我都用field来管理，如果只有checkbox要单独管理，那不太合理。

而且目前组件行为是支持的boolean，只是ts报错，把ts定义文件改下就好了。行为不变

@YunMeng99 YunMeng99 added the improvement improve some features label Aug 11, 2023
@YSMJ1994 YSMJ1994 added the Next release issues to close in next release label Nov 10, 2023
YunMeng99 added a commit that referenced this issue Nov 10, 2023
@YunMeng99
fix(Checkbox): fixed checkbox ts errors close #3931
0d19cd4
@YunMeng99 YunMeng99 linked a pull request Nov 10, 2023 that will close this issue
fix(Checkbox): fixed checkbox ts errors close #3931 #4519
Merged
YunMeng99 added a commit that referenced this issue Nov 15, 2023
@YunMeng99
fix(Checkbox): add ts close #3931
4db00b3
YSMJ1994 added a commit that referenced this issue Nov 15, 2023
@YSMJ1994
chore(Checkbox): adjust test case for #3931
fa73367
YSMJ1994 added a commit that referenced this issue Nov 15, 2023
@YunMeng99 @YSMJ1994
fix(Checkbox): support boolean value type, close #3931 (#4519)
26a08d8 
* fix(Checkbox): fixed checkbox ts errors close #3931

* fix(Checkbox): add ts close #3931

* chore(Checkbox): adjust test case for #3931

---------

Co-authored-by: 珵之 <chengzhi.zpc@alibaba-inc.com>
@YSMJ1994 YSMJ1994 linked a pull request Nov 15, 2023 that will close this issue
fix(*): remove it.only #4528
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@YunMeng99 YunMeng99

Labels
improvement improve some features Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
5 participants
@cwtuan @youluna @YSMJ1994 @fusion-design-bot @YunMeng99