Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Checkbox): fixed checkbox ts errors close #3931 #4519

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

YunMeng99
Copy link
Contributor

No description provided.

@YunMeng99 YunMeng99 linked an issue Nov 10, 2023 that may be closed by this pull request
Copy link
Contributor

@YSMJ1994 YSMJ1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checkbox.Group的相关属性比如 dataSource, value, onChange 也需要同步调整
虽然只是添加了类型和文档,但这代表对外开放某些新能力,也是需要通过编写测试用例来确保新的能力可以正常运行的

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dcd19d7) 90.75% compared to head (42667e8) 5.16%.

❗ Current head 42667e8 differs from pull request most recent head fa73367. Consider uploading reports for the commit fa73367 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #4519       +/-   ##
==========================================
- Coverage   90.75%   5.16%   -85.59%     
==========================================
  Files         305     305               
  Lines       17903   17903               
  Branches     5289    5289               
==========================================
- Hits        16248     925    -15323     
- Misses       1638   16978    +15340     
+ Partials       17       0       -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YSMJ1994 YSMJ1994 self-requested a review November 15, 2023 13:27
@YSMJ1994 YSMJ1994 merged commit 26a08d8 into master Nov 15, 2023
18 of 19 checks passed
@YSMJ1994 YSMJ1994 deleted the fix/Checkbox-ts-error branch November 15, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Checkbox] Checkbox的value类型,应该包含boolean
2 participants