Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider]Slider onChange 钩子中用 setState 后，会导致轮播失效。 #4533

Closed
hxuena opened this issue Nov 17, 2023 · 2 comments · Fixed by #4535
Closed

[Slider]Slider onChange 钩子中用 setState 后，会导致轮播失效。 #4533

hxuena opened this issue Nov 17, 2023 · 2 comments · Fixed by #4535
Assignees
@kyokaxin
Labels
🐞 Bug Something isn't working Next release issues to close in next release

Comments

@hxuena
Copy link

hxuena commented Nov 17, 2023

Component

Slider

Reproduction link

https://riddle.alibaba-inc.com/riddles/44e5f670

Steps to reproduce

Slider onChange 钩子中用 setState 后，轮播失效。具体表现如：有 4张卡片，从1 -> 2，正常；从2->3，在切到3后，会立马切回 1.
@github-actions GitHub Actions
Copy link

这是您为 Fusion/Next 提的第一个 issue，感谢您对 Fusion 的信任和支持，我们会尽快进行处理。

@YSMJ1994 YSMJ1994 added 🐞 Bug Something isn't working Next release issues to close in next release labels Nov 17, 2023
@kyokaxin kyokaxin mentioned this issue Nov 20, 2023
Merged
YSMJ1994 pushed a commit that referenced this issue Nov 23, 2023
@kyokaxin
fix(Slider):some props should not affect index at didUpdate, close #4533
7d2bc79 
 (#4535)

Co-authored-by: chenkeyao.chenkeya <chenkeyao.chenkeya@alibaba-inc.com>
@YSMJ1994
Copy link
Contributor

Fixed at 1.26.34

owenchen1004 pushed a commit to owenchen1004/next that referenced this issue Dec 5, 2023
@kyokaxin @owenchen1004
fix(Slider):some props should not affect index at didUpdate, close al…
6a14e23 
…ibaba-fusion#4533 (alibaba-fusion#4535)

Co-authored-by: chenkeyao.chenkeya <chenkeyao.chenkeya@alibaba-inc.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyokaxin kyokaxin

Labels
🐞 Bug Something isn't working Next release issues to close in next release
Projects
DAILY WORK
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Slider): onChange does not affect activeIndex alibaba-fusion/next
3 participants
@YSMJ1994 @hxuena @kyokaxin