fix(DatePicker2): Unable to enter space to enter time #4853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eternalsky
requested changes
Jun 20, 2024
| ); | ||
| const DatePicker_triggerClickKeycode = wrapper.find('Overlay').props()['triggerClickKeycode']; | ||
| assert(DatePicker_triggerClickKeycode.length === 0); | ||
| changeInput('2020-11-11 09:23:23'); |
There was a problem hiding this comment.
感觉这个测试用例无法覆盖相应的变化，simulate change 是模拟的 change 事件，并不是一个一个字符输入进去的，因此无法模拟中间输入空格的情况，相当于把 2020-11-11 09:23:23 一下子输入进去。这个原本就是支持的。写测试用例还是应该遵循，首先用测试用例能复现 issue，然后再通过修改 src 来修复 issue。
| @@ -745,6 +745,7 @@ class Picker extends React.Component { | |||
| } | |||
| onPosition={this.getCurrentAlign} | |||
| canCloseByTrigger={false} | |||
| triggerClickKeycode={[]} | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4790