Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for scripts #305

Merged
merged 10 commits into from Aug 11, 2022
Merged

Add docs for scripts #305

merged 10 commits into from Aug 11, 2022

Conversation

xieyxclack
Copy link
Collaborator

@xieyxclack xieyxclack commented Aug 9, 2022

  • minor fix for scripts for distributed mode
  • docs for scripts (as examples)
  • move federatedscope/example_configs to scripts/example_configs

@@ -0,0 +1,8 @@
# SHA
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A shell script in the folder of configuration files. Is it possible to organize the shell scripts better?

joneswong
joneswong previously approved these changes Aug 10, 2022
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved.

Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rayrayraykk rayrayraykk merged commit 72d3b22 into alibaba:master Aug 11, 2022
@xieyxclack xieyxclack deleted the readme_scripts branch August 15, 2022 09:16
Schichael pushed a commit to Schichael/FederatedScope_thesis that referenced this pull request Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants