Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] FLIT for federated graph classification/regression #87

Merged
merged 12 commits into from
May 23, 2022
Merged

[feature] FLIT for federated graph classification/regression #87

merged 12 commits into from
May 23, 2022

Conversation

wanghh7
Copy link
Contributor

@wanghh7 wanghh7 commented May 13, 2022

No description provided.

@CLAassistant
Copy link

CLAassistant commented May 13, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@wanghh7 wanghh7 closed this May 13, 2022
@wanghh7 wanghh7 reopened this May 13, 2022
@wanghh7 wanghh7 closed this May 13, 2022
@wanghh7 wanghh7 reopened this May 13, 2022
@joneswong joneswong changed the title Dev flit [feature] FLIT for federated graph classification/regression May 13, 2022
@joneswong joneswong self-assigned this May 13, 2022
@joneswong joneswong added the Feature New feature label May 13, 2022
rayrayraykk
rayrayraykk reviewed May 13, 2022
View reviewed changes
Copy link
Collaborator

@rayrayraykk rayrayraykk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete all the data files and do not change the permissions of script files.
And see the inline comments, thanks.

federatedscope/core/monitors/metric_calculator.py Outdated Show resolved Hide resolved
federatedscope/core/monitors/metric_calculator.py Outdated Show resolved Hide resolved
federatedscope/core/monitors/metric_calculator.py Outdated Show resolved Hide resolved
federatedscope/core/monitors/metric_calculator.py Outdated Show resolved Hide resolved
federatedscope/core/splitters/graph/scaffold_lda_splitter.py Outdated Show resolved Hide resolved
federatedscope/core/splitters/graph/scaffold_lda_splitter.py Show resolved Hide resolved
federatedscope/gfl/flitplus/vat.py Outdated Show resolved Hide resolved
federatedscope/main.py Outdated Show resolved Hide resolved
federatedscope/main.py Outdated Show resolved Hide resolved
yxdyc
yxdyc reviewed May 16, 2022
View reviewed changes
Copy link
Collaborator

@yxdyc yxdyc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this PR was rebased and committed some existing codes, leading to +83,232 different lines and there are Empty file. logs for many changed files, e.g., see scripts/format.sh.

Please consider addressing this before merging, to avoid the strange commit history.

joneswong
joneswong approved these changes May 23, 2022
View reviewed changes
Copy link
Collaborator

@joneswong joneswong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved!

@joneswong joneswong merged commit e625a0d into alibaba:master May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrayraykk rayrayraykk rayrayraykk left review comments

@yxdyc yxdyc yxdyc left review comments

@joneswong joneswong joneswong approved these changes

Assignees

@joneswong joneswong

Labels
Feature New feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wanghh7 @CLAassistant @joneswong @rayrayraykk @yxdyc